S4: Upgrade Provision FAILS if you are using bind9.7 flat files

[Charles Tryon]

This is a problem!  I have a test system where I provisioned the domain
from scratch a couple of months ago, using bind9.7 FLAT FILES.  I've been
upgrading git on a fairly regular basis, and running "upgradeprovision"
each time I install the new binaries.  I just did a git pull a few hours
ago, and now I get the following error for the upgradeprovision tool.  I
can not restart Samba4 now.  :(

<samba4:dev>? sudo /usr/local/samba/sbin/upgradeprovision
[sudo] password for ctryon:
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
Creating a reference provision
No IPv6 address will be assigned
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
ldb: unable to stat module ${PREFIX}/modules/ldb : No such file or directory
Traceback (most recent call last):
  File "/usr/local/samba/sbin/upgradeprovision", line 1786, in <module>
    provision_logger)
  File
"/usr/local/samba/lib/python2.6/site-packages/samba/upgradehelpers.py",
line 273, in newprovision
    useeadb=True)
  File
"/usr/local/samba/lib/python2.6/site-packages/samba/provision/__init__.py",
line 1757, in provision
    am_rodc=am_rodc, lp=lp)
  File
"/usr/local/samba/lib/python2.6/site-packages/samba/provision/__init__.py",
line 1491, in provision_fill
    targetdir=targetdir, site=DEFAULTSITE)
  File
"/usr/local/samba/lib/python2.6/site-packages/samba/provision/sambadns.py",
line 993, in setup_ad_dns
    dnsdomain=names.dnsdomain, dns_backend=dns_backend)
  File
"/usr/local/samba/lib/python2.6/site-packages/samba/provision/sambadns.py",
line 822, in create_named_conf
    "BIND9_DLZ_MODULE": dlz_module_path,
  File "/usr/local/samba/lib/python2.6/site-packages/samba/__init__.py",
line 291, in setup_file
    data = read_and_sub_file(template, subst_vars)
  File "/usr/local/samba/lib/python2.6/site-packages/samba/__init__.py",
line 277, in read_and_sub_file
    check_all_substituted(data)
  File "/usr/local/samba/lib/python2.6/site-packages/samba/__init__.py",
line 265, in check_all_substituted
    text[var_start:var_end+1])
Exception: Not all variables substituted: ${PREFIX}
A transaction is still active in ldb context [0xa124300] on
/usr/local/samba/private/sam.ldb
A transaction is still active in ldb context [0xa7af0c8] on
/usr/local/samba/private/idmap.ldb
A transaction is still active in ldb context [0xa1b2fc8] on
/usr/local/samba/private/secrets.ldb
A transaction is still active in ldb context [0xb0e9a30] on
/usr/local/samba/private/privilege.ldb


-- 
    Charles Tryon
_________________________________________________________________________
      "It's the job that's never started that takes longest to finish."
                                 -- Samwise Gamgee