s4: "repl_meta_data" LDB module compilation warning

[Matthias Dieter Wallnöfer]

It is the value from "expectedTimeDo" in your commit: 
https://lists.samba.org/archive/samba-cvs/2011-November/104038.html
> @@ -465,6 +482,23 @@ class dbcheck(object):
>
>           show_dn = True
>           if got_repl_property_meta_data:
> +            rdn = (str(dn).split(","))[0]
> +            if rdn == "CN=Deleted Objects":
> +                isDeletedAttId = 131120
> +                # It's 29/12/9999 at 23:59:59 UTC as specified in MS-ADTS 7.1.1.4.2 Deleted Objects Container
> +
> +                expectedTimeDo = 2650466015990000000
> +                originating = self.get_originating_time(obj["replPropertyMetaData"], isDeletedAttId)
> +                if originating != expectedTimeDo:
> +                    if self.confirm_all("Fix isDeleted originating_change_time on '%s'" % str(dn), 'fix_time_metadata'):
> +                        nmsg = ldb.Message()
> +                        nmsg.dn = dn
> +                        nmsg["isDeleted"] = ldb.MessageElement("TRUE", ldb.FLAG_MOD_REPLACE, "isDeleted")
> +                        error_count += 1
> +                        self.samdb.modify(nmsg, controls=["provision:0"])
> +
> +                    else:
> +                        self.report("Not fixing isDeleted originating_change_time on '%s'" % str(dn))
>               for att in list_attrs_seen:
>                   if not att in list_attrs_from_md:
>                       if show_dn:


Matthieu Patou schrieb:
> Hi Mathias,
>
> Good shot !
>
> If you are sure on the NTTIME value then it's a good patch !
>
>
> Matthieu.
>
> On 04/01/2012 11:47, Matthias Dieter Wallnöfer wrote:
>> ekacnet,
>>
>> during compilation of s4 on a 32 bit machine I have noticed an out of 
>> range warning regarding an integer literal 
>> (DELETED_OBJECT_CONTAINER_CHANGE_TIME) in "repl_meta_data.c". To fix 
>> the issue I propose the following patch (please consider the commit 
>> explaination): 
>> http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=commitdiff;h=7d6bf072a6c463aa927ea313f8ab31020051fa52
>>
>> I have launched dbcheck (which tests for this) against s4 32 + 64 bit 
>> and against Windows Server as well. All iterations passed, so it 
>> should be correct?
>>
>> Cheers,
>> Matthias
>
>