Julia Lawall julia.lawall at
Wed Feb 29 08:24:06 MST 2012

It is probably not vary important, but the following code in 
source4/lib/ldb/pyldb.c is a bit sloppy:

         if (ret != LDB_SUCCESS) {
                 PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx);
                 return NULL;

PyErr_LDB_ERROR_IS_ERR_RAISE tests ret again in the same way and if the 
test succeeds returns, making the rest dead code.


More information about the samba-technical mailing list