[PATCH] add missing talloc_free

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Feb 26 01:14:00 MST 2012

On Sun, Feb 26, 2012 at 07:22:06AM +0100, Julia Lawall wrote:
> On Sat, 25 Feb 2012, Richard Sharpe wrote:
> >On Sat, Feb 25, 2012 at 12:32 PM, Julia Lawall <julia.lawall at lip6.fr> wrote:
> >>There seem to be a number of places in the samba code where calls to
> >>talloc_free are omitted.  This patch fixes some cases.
> >
> >Are you aware of the way that talloc works? It seems likely to me that
> >when a talloc_free is done somewhere further up in the call stack that
> >if frees all memory.
> OK, I see from the behavior of talloc how this could be the case.
> But still it seems odd to free a value on some failures and not free
> it on others, unless there is a reason to do so.

Right. talloc fosters sloppy programming at times. I many of
those cases should be fixed, although they might not be real


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list