Stefan (metze) Metzmacher
metze at samba.org
Fri Feb 17 02:06:55 MST 2012
That looks like a really nice infrastructure!
It'll really help a lot to cleanup our code.
I have just a few cosmetic remarks:
When first reading the name 'msg_stream', I'm a bit confused, because
it could imply that we're using some sort of stream sockets.
After reading the code my impression that 'msg_channel' could be a
but I'm not a native speaker...(Native speakers please comment on this)
What do you think about this?
Did you intend to add msg_write_send/recv also based on a 'struct
msg_stream' (or whatever name it endup with)
For msg_stream_send/recv I propose to add '_setup' in the function name
Why does dbwrap_record_watch_send() use the sync msg_stream() function
instead of msg_stream_send/recv?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 262 bytes
Desc: OpenPGP digital signature
More information about the samba-technical