[PATCH] smb2 FSCTL_SRV_COPYCHUNK support

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Feb 15 08:05:39 MST 2012


On Wed, Feb 15, 2012 at 06:51:58AM -0800, Richard Sharpe wrote:
> 1. It gives VFS writers the ability to handle those operations in
> their specific ways and to define their own FSCTSLs if they want to
> without them having to modify the body of Samba.
> 
> 2. I want that functionality in a VFS for Amazon's S3 service that I am writing.
> 
> With respect to making the VFS thread safe, perhaps we should invest
> some time on that. I am using a thread in the VFS module mentioned
> above, although that is not really the correct model. However, it has
> not really exposed too many issues so far. You can't use talloc_tos()
> in the VFS code if those objects are going to be passed to threads but
> that is surely a matter of documentation.

If you are using threads in your VFS module, how do you pass
that up to the core SMB handling engine? The _send/_recv
model makes it possible to keep the main engine
single-threaded but opens up the possibility to do a
threaded implementation in the VFS. See for example the
vfs_aio_pthread module that Jeremy added lately. It still
uses the posix AIO based VFS calls, but I think those should
be converted to pread_send/recv and pwrite_send/recv, hiding
the ugliness of the Posix API in some default module.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list