[PATCH] smb2 FSCTL_SRV_COPYCHUNK support
jra at samba.org
Tue Feb 14 16:56:38 MST 2012
On Wed, Oct 19, 2011 at 06:09:46PM +0200, David Disseldorp wrote:
> On Wed, 19 Oct 2011 15:47:50 +0200
> "Stefan (metze) Metzmacher" <metze at samba.org> wrote:
> > I pushed all the header related stuff to autobuild.
> > > I've reworked the existing SMB2 ioctl handler code to use separate
> > > source files per ioctl device type. Please let me know if this is
> > > what you had in mind:
> > Partly, I'll reply more detailed in the next days (if not please ping
> > me again).
> Here's the new round of copychunk changes, based against
> smb2_ioctl_split_dev_type for now. I'll rebase them again with your
> detailed response.
> Changes since smb2_copychunk_rb2:
> - fixes for SMB2 ioctl error reporting / handling in line with MS-SMB2
> - basic data integrity checks for the copychunk tests.
> - rebased on top of smb2_ioctl_split_dev_type, with some commits
> The following changes since commit
> s3-smb2: split ioctl handler code on device type (2011-10-19 17:27:51
> are available in the git repository at:
> git://git.samba.org/ddiss/samba.git smb2_copychunk_rb4
> David Disseldorp (11):
> idl: add copychunk and request_resume_key ioctl definitions
> s4-torture: Add tests for the smb2 copychunk ioctl
> s3-server: add smb2 FSCTL_SRV_REQUEST_RESUME_KEY support
> s3-vfs: add copy_chunk vfs hook
> s3-server: add support for smb2 FSCTL_SRV_COPYCHUNK
> s3-server: report copychunk limits in invalid param response
> s4-torture: split common copychunk ioctl test code into helpers
> s3-vfs: add vfs_btrfs module
> s4-torture: add smb2 copychunk ioctl tests
> s4-torture: smb2 copychunk data integrity checks
> s3-server: remove smb2 ioctl error response assumption
I'd still like to get the COPYCHUNK VFS changes into master
in order to have them for a Samba4.0 release.
Metze, are you happy with the :
+static NTSTATUS vfswrap_copy_chunk(struct vfs_handle_struct *handle,
+ struct files_struct *src_fsp,
+ SMB_OFF_T src_off,
+ struct files_struct *dest_fsp,
+ SMB_OFF_T dest_off,
+ SMB_OFF_T num,
+ SMB_OFF_T *copied)
interface for the VFS ?
More information about the samba-technical