[PATCH] Fix starting of dependent selftest environments
abartlet at samba.org
Tue Feb 14 14:30:16 MST 2012
On Tue, 2012-02-14 at 16:42 +0100, Jelmer Vernooij wrote:
> On 02/13/2012 12:43 PM, Andrew Bartlett wrote:
> > Jelmer,
> > I've found a bug in selftest.pl, where the starting of a dependent
> > environment (such as s3member requiring the s4 DC) didn't register that
> > environment at the top level, in the main cache of environments.
> I don't see why the main cache of environments should know about it?
> Isn't it sufficient to do the caching in the target itself?
Sadly no, otherwise when the top level needs to start the environment
for a test that explicitly uses it, it gets set up again.
I guess you are saying that the target should notice during the re-setup
that the env is running. For some reason that doesn't work - perhaps
your eyes can spot that better than I could. 'for some reason' probably
isn't a good enough excuse for this level of code change however...
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical