s3-printing: Add new printers to registry.

[Andreas Schneider]

On Friday 10 February 2012 12:53:39 Andrew Bartlett wrote:
> On Fri, 2012-02-10 at 00:34 +0100, Jelmer Vernooij wrote:
> > Hi Andreas, Björn,
> > 
> > On 02/09/2012 04:40 PM, Andreas Schneider wrote:
> > > The branch, master has been updated
> > > 
> > >         via  5ec1273 s3-printing: Add new printers to registry.
> > >        
> > >        from  2464a7b s3-libsmb: Remove obsolete smb_krb5_locate_kdc.
> > > 
> > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > 
> > > 
> > > - Log -----------------------------------------------------------------
> > > commit 5ec12732c3092d248a374ae7af155a409c7ee88e
> > > Author: Björn Baumbach<bb at sernet.de>
> > > Date:   Tue Feb 7 11:41:54 2012 +0100
> > > 
> > >      s3-printing: Add new printers to registry.
> > >      
> > >      This fixes bug #8554, #8612 and #8748.
> > >      
> > >      Pair-Programmed-With: Stefan Metzmacher<metze at samba.org>
> > >      
> > >      Autobuild-User: Andreas Schneider<asn at cryptomilk.org>
> > >      Autobuild-Date: Thu Feb  9 16:39:04 CET 2012 on sn-devel-104
> > 
> > After this change (or perhaps an earlier one?) I'm unable to push
> > changes to autobuild. The last two builds fail with:
> > 
> > [275/1226 in 17m41s] samba3.posix_s3.rpc.spoolss.printer (s3dc)
> > Testing DsSpooler<->  SetPrinter relations
> > Testing GetPrinter level 2
> > Testing SetPrinter level 2
> > Testing GetPrinterDataEx(DsSpooler - description)
> > Testing SetPrinter level 2
> > Testing GetPrinterDataEx(DsSpooler - location)
> > Testing GetPrinter level 2
> > Testing GetPrinterDataEx(DsSpooler - description)
> > Testing GetPrinterDataEx(DsSpooler - driverName)
> > WARNING!: ../source4/torture/rpc/spoolss.c:3648: r.out.result was
> > WERR_BADFILE, expected WERR_OK: GetPrinterDataEx(DsSpooler - driverName)
> > failed WARNING!: ../source4/torture/rpc/spoolss.c:5509: Expression
> > `test_GetPrinterDataEx(tctx, p, handle, "DsSpooler",
> > "driverName",&type,&data,&needed)' failed: failed to query
> > UNEXPECTED(failure): samba3.posix_s3.rpc.spoolss.printer
> > .addprinterex.printerdata_dsspooler REASON: _StringException:
> > _StringException: ../source4/torture/rpc/spoolss.c:7879: Expression
> > `test_PrinterData_DsSpooler(tctx, p,&t->handle, t->info2.printername)'
> > failed: failed to test printer data winreg dsspooler
> > 
> > FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
> 
> I see the same in local testing.

I see the same too. I wonder how the patch could get in, I got a mail that the 
build failed. I'm trying to hunt this down but it is really strange.

Should I revert it till I have it fixed?



	-- andreas

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
www.cryptomilk.org                asn at cryptomilk.org