[PATCH] Remove unused functions with callcatcher
abartlet at samba.org
Wed Feb 8 22:40:09 MST 2012
I've prepared a branch with the unused functions that I've found using
the callcatcher tool.
As Samba has developed, a good number of utility functions have been
developed, and in some cases have become orphans - no longer being
called from anywhere in the code base.
Cleaning these out reduces (slightly) our binary size, but also allows
us to find other functions that might also be uncalled from anywhere
inside Samba, and avoids us spending effort porting them when codebase
wide changes are made.
In other cases, it shows the value of higher level work, such as the
GSSAPI code for session setup, as delicate utility functions that
supported that system become obsolete.
This is the list of functions I've determined are unused (both by
compilation and by git grep). Please let me know soon if you wish to
adopt any of these orphan functions and would prefer I skip removing
dup_registry_value() and free_registry_value()
This is not the full list, and I attach the patch I made to callcatcher
to make it work with waf. Run it as CC="callcatcher gcc" ./configure.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 627 bytes
Desc: not available
More information about the samba-technical