[PATCH] Remove sys_poll() (raceless signal handler)?

Andrew Bartlett abartlet at samba.org
Wed Feb 8 22:14:12 MST 2012

This patch comes out of some work I've been doing with callcatcher, to
find dead code in Samba.  

It seems we do not need the sys_poll() wrapper, as something else
(tevent presumably) handles the creation of the signal file descriptor.

Either that, or we have a problem with the 'race-less signal handler',
as none of the signal handlers call the magic sys_select_signal()

I'm still unclear why we call poll directly, particularly in
smbd/process.c, hence why I post these patches for review, but more
particularly for comment.


Andrew Bartlett
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-util-Remove-unused-sys_select_signal.patch
Type: text/x-patch
Size: 1620 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120209/34ec9973/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lib-util-Remove-sys_poll-as-it-is-no-longer-needed.patch
Type: text/x-patch
Size: 8468 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120209/34ec9973/attachment-0001.bin>

More information about the samba-technical mailing list