getpass regressions on Solaris/Illumos - 3.6 and master.
samba at ira.wakeful.net
Mon Feb 6 12:15:55 MST 2012
On Mon, Feb 6, 2012 at 12:29 PM, Jeremy Allison <jra at samba.org> wrote:
> On Mon, Feb 06, 2012 at 05:19:45PM +0100, Andreas Schneider wrote:
> > On Monday 06 February 2012 16:10:09 Jelmer Vernooij wrote:
> > > Am 06/02/12 15:29, schrieb Andreas Schneider:
> > >
> > > agreed, but it should be something different than getpass altogether
> > > since getpass' signature is problematic.
> > >
> > > Since that wouldn't be a standard function it should probably live in
> > > libutil rather than libreplace.
> > Yes, call git smb_get_passwd() or somthing like that and move it to
> > util.
> It's this what I originally proposed ? :-)
As far as this proposal goes: Just look at the portable SSH implementation
of "readpassphrase". (openbsd-compat/readpassphrase.c/h, in the tarball.)
It should address the signature and portability issues. (I'd trust that
they have this right.)
You'll have to rename it so you don't clash with it on *BSD systems. But
at least you'll have something with the right signature, and that has some
vetting, and that other people are actually using in the field. ;) Also if
there's changes hopefully you can just merge up.,..
The last thing I'd want here is new code totally from scratch to solve
this. As is, I think I saw a bug in the current code after reviewing the
OpenSSH code. (How do we handle C-z here? And what if they flip echo back
More information about the samba-technical