getpass regressions on Solaris/Illumos - 3.6 and master.

[Andreas Schneider]

On Monday 06 February 2012 16:10:09 Jelmer Vernooij wrote:
> Am 06/02/12 15:29, schrieb Andreas Schneider:
> > On Monday 30 January 2012 17:18:54 Jeremy Allison wrote:
> >> Or optionally, what about (for master at least) simply
> >> requiring getpassphrase in Samba ?
> >> 
> >> Change the replacement rep_getpass to be rep_getpassphrase
> >> for systems that don't support rep_getpass.
> >> 
> >> Comments ?
> > 
> > Am I the only one having the following sentence in the getpass() manpage:
> > 	This function is obsolete.  Do not use it.
> > 
> > We should simply use always use our implementation.
> 
> agreed, but it should be something different than getpass altogether
> since getpass' signature is problematic.
> 
> Since that wouldn't be a standard function it should probably live in
> libutil rather than libreplace.

Yes, call git smb_get_passwd() or somthing like that and move it to samba-
util.

 
	-- andreas

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
www.cryptomilk.org                asn at cryptomilk.org