getpass regressions on Solaris/Illumos - 3.6 and master.

[Ira Cooper]

On Mon, Feb 6, 2012 at 9:29 AM, Andreas Schneider <asn at cryptomilk.org>
wrote:
>
> On Monday 30 January 2012 17:18:54 Jeremy Allison wrote:
> > Or optionally, what about (for master at least) simply
> > requiring getpassphrase in Samba ?
> >
> > Change the replacement rep_getpass to be rep_getpassphrase
> > for systems that don't support rep_getpass.
> >
> > Comments ?
>
> Am I the only one having the following sentence in the getpass() manpage:
>
>
>
>        This function is obsolete.  Do not use it.
>
>
>
>
> We should simply use always use our implementation.


http://netbsd.gw.com/cgi-bin/man-cgi?getpass++NetBSD-current

To quote:
----

STANDARDS
    The getpass() function appeared in Version 2 of the Single UNIX
    Specification (``SUSv2''), but it was already marked as legacy.  The
    function was removed in the IEEE Std 1003.1-2001 (``POSIX.1'') standard.

----

I think that's a much better explanation of the situation.

Even if a vendor does drop support fot getpass/getpassphrase,  I believe we
have autoconf/waf checks for getpass, so if it is not there, we'll just use
our own anyways.

-Ira