errors3 and gssapi
abartlet at samba.org
Wed Feb 1 13:34:34 MST 2012
On Wed, 2012-02-01 at 11:44 -0500, simo wrote:
> On Wed, 2012-02-01 at 16:53 +0100, Andreas Schneider wrote:
> > Hello,
> > Jelmer linked errors3 against gssapi, but it doesn't use any function from
> > gssapi. Looking at libsmb/errormap.c it just needs some constants from the
> > header file for the function map_nt_error_from_gss().
> > A 'git grep' shows that this function isn't used anywhere. So it is dead code
> > at least at the moment.
> > Can we remove that code? Should it be moved to a different place?
> +1 to removing dead code and unwanted dependencies.
This became dead when the gssapi smb sealing code moved to gensec.
I'm happy for these to go away - the correct NT error code to return
depends as much on the situation as on the error. Also the gss minor
code often provides the better mapping for any error code.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical