[PATCH] DNS patches for review

[Andrew Bartlett]

On Fri, 2012-12-28 at 18:31 +1100, Andrew Bartlett wrote:
> On Fri, 2012-12-28 at 07:02 +0100, Kai Blin wrote:
> > On 2012-12-28 05:09, Andrew Bartlett wrote:
> > > index ba597cf..d2cf42f 100755
> > > --- a/source4/scripting/bin/samba_upgradedns
> > > +++ b/source4/scripting/bin/samba_upgradedns
> > > @@ -449,10 +449,17 @@ if __name__ == '__main__':
> > >                      "DNSNAME" : dnsname }
> > >                             )
> > >  
> > > +            res = ldbs.sam.search(base=domaindn, scope=ldb.SCOPE_DEFAULT,
> > > +                                  expression='(sAMAccountName=dns-%s)' % (hostname),
> > > +                                  attrs=["msDS-KeyVersionNumber"])
> > > +            if "msDS-KeyVersionNumber" in res[0]:
> > > +                dns_key_version_number = int(res[0]["msDS-KeyVersionNumber"][0])
> > > +
> > >              secretsdb_setup_dns(ldbs.secrets, names,
> > >                                  paths.private_dir, realm=names.realm,
> > >                                  dnsdomain=names.dnsdomain,
> > > -                                dns_keytab_path=paths.dns_keytab, dnspass=dnspass)
> > > +                                dns_keytab_path=paths.dns_keytab, dnspass=dnspass,
> > > +                                key_version_number=dns_key_version_number)
> > 
> > How do you get a dns_key_version_number if the above if statement fails?
> > Either we're sure the if statement never fails, and then it's pointless,
> > or we need to come up with a fake number ourselves, or raise an exception.
> > 
> > Same logic in the join.py code.
> 
> Thanks, I'll fix that up.  The default value needs to be 1 (really only
> applies to windows 2000 mode, but worth doing right). 

Attached are all my DNS patches to date.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-scripting-join.py-Handle-creating-the-dns-NAME-accou.patch
Type: text/x-patch
Size: 10812 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/4b7feea0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-scripting-samba_upgradedns-Tighten-up-exception-and-.patch
Type: text/x-patch
Size: 3517 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/4b7feea0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-selftest-Test-creation-of-the-dns-SERVER-account-dur.patch
Type: text/x-patch
Size: 1125 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/4b7feea0/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-selftest-Start-internal-DNS-server-on-domain-provisi.patch
Type: text/x-patch
Size: 867 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/4b7feea0/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-scripting-samba_upgradedns-Only-look-for-IPv4-IPv6-a.patch
Type: text/x-patch
Size: 2525 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/4b7feea0/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-selftest-Add-a-basic-test-of-samba_upgradedns.patch
Type: text/x-patch
Size: 3608 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/4b7feea0/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-torture-Ensure-that-GSSAPI-and-SPNEGO-packets-are-ac.patch
Type: text/x-patch
Size: 5794 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/4b7feea0/attachment-0006.bin>