[PATCH] samba-tool ntacl do a proper VFS connect

[Andrew Bartlett]

On Fri, 2012-12-28 at 15:07 +1100, Andrew Bartlett wrote:
> Attached for review is the small collection of patches I've been working
> on over the holidays, now that I have written some tests for them.
> 
> Most of the substantive changes have been posted to one or other list,
> or in bugzilla already, but what I hadn't asked for yet is specific
> review (and optionally push). 
> 
> Here are the patches to have samba-tool ntacl do a proper VFS
> connect to a specific share, which makes it give less warnings and uses
> the VFS layer more correctly.
> 
> I know most folks are busy with family over this holiday time, but if I
> could get some review on these changes, i would appreciate it.

On Simo's request, the attached revised patches try to clarify why the
crate_conn_struct() function was split into create_conn_struct() and
create_conn_struct_cwd().  

Simo, I would rather not make it create_conn_struct_nocwd() instead,
because in the long term this is clearer, and it makes it clear in the
callers that this code changes the current working directory (which
seems to have surprised Jeremy, who wrote in the function header
comment:

Note: this performs a vfs connect and CHANGES CWD !!!! JRA.

If we have to have two names (which we do), encoding this clearly in the
name seems the most reasonable thing.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smbd-Split-create_conn_struct-into-a-fn-that-does-no.patch
Type: text/x-patch
Size: 11282 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/9e613847/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-pysmbd-Convert-pysmbd-to-take-an-optional-service-to.patch
Type: text/x-patch
Size: 14372 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/9e613847/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-scripting-ntacls-Optionally-allow-the-service-to-be-.patch
Type: text/x-patch
Size: 3879 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/9e613847/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-scripting-provision-Set-sysvol-ACLs-on-the-sysvol-sh.patch
Type: text/x-patch
Size: 7661 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/9e613847/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-pysmbd-Change-to-keyword-based-arguments.patch
Type: text/x-patch
Size: 10663 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/9e613847/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-samba-tool-Add-service-argument-to-samba-tool-ntacl-.patch
Type: text/x-patch
Size: 4019 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121228/9e613847/attachment-0011.bin>