[PATCH] Recent coverity changes added directory_create_or_exist() checks to many directories.

Andreas Schneider asn at samba.org
Mon Dec 24 00:58:55 MST 2012


On Saturday, December 22, 2012 10:22:50 Andrew Bartlett wrote:
> On Fri, 2012-12-21 at 15:18 -0800, Jeremy Allison wrote:
> > Fix to make "make test" work again in master, no matter what the umask.

Thanks for the fix.

> I'm not entirely happy with the original change (we should only enforce
> directory permissions when not doing so would be a security disaster),
> but for this change:

I think the questions is if this function should enforce uid and permissions 
at all, or if we should add an argument to disable enforcement.


	-- andreas



More information about the samba-technical mailing list