Can we include "includes" a little later?
realrichardsharpe at gmail.com
Fri Dec 7 12:58:34 MST 2012
On Fri, Dec 7, 2012 at 11:50 AM, Andrew Bartlett <abartlet at samba.org> wrote:
> On Fri, 2012-12-07 at 09:09 -0800, Richard Sharpe wrote:
>> Hi folks,
>> In our build there are lots of instances of these warnings:
>> warning: "PRIi64" redefined
>> In file included from include/includes.h:23,
>> from libnet/libnet_dssync_keytab.c:21:
>> ./../lib/replace/../replace/replace.h:91:1: warning: this is the
>> location of the previous definition
>> In file included from
>> from include/smb_krb5.h:36,
>> from libnet/libnet_dssync_keytab.c:22:
>> These come about because we include includes.h before smb_krb5.conf in
>> #include "includes.h"
>> #include "smb_krb5.h"
>> #include "ads.h"
>> #include "libnet/libnet_dssync.h"
>> #include "libnet/libnet_keytab.h"
>> #include "librpc/gen_ndr/ndr_drsblobs.h"
>> includes.h pulls in replace.h which defines all those PRIxxx things
>> before the system includes that get pulled in by smb_krb5.h.
>> It sure would remove a lot of useless noise warnings if we changed the
>> order of includes ...
> No, it would just cause other problems.
I should have said it more loudly.
THIS IS A PROBLEM WITH THE BUILD IN THE COMPANY I CURRENTLY WORK FOR.
WE WILL FIX THE BUILD :-)
Sorry for the noise.
More information about the samba-technical