Can we include "includes" a little later?
Richard Sharpe
realrichardsharpe at gmail.com
Fri Dec 7 10:09:27 MST 2012
Hi folks,
In our build there are lots of instances of these warnings:
/home/rsharpe/dev-src/buildroot/tools/x86_gcc4.2.4/usr/include/machine/_inttypes.h:67:1:
warning: "PRIi64" redefined
In file included from include/includes.h:23,
from libnet/libnet_dssync_keytab.c:21:
./../lib/replace/../replace/replace.h:91:1: warning: this is the
location of the previous definition
In file included from
/home/rsharpe/dev-src/buildroot/tools/x86_gcc4.2.4/usr/include/inttypes.h:32,
from
/home/rsharpe/dev-src/buildroot/tools/x86_gcc4.2.4/usr/include/krb5-types.h:9,
from
/home/rsharpe/dev-src/buildroot/tools/x86_gcc4.2.4/usr/include/krb5.h:40,
from include/smb_krb5.h:36,
from libnet/libnet_dssync_keytab.c:22:
These come about because we include includes.h before smb_krb5.conf in
source3/libnet/libnet_dssync_keytab.c:
#include "includes.h"
#include "smb_krb5.h"
#include "ads.h"
#include "libnet/libnet_dssync.h"
#include "libnet/libnet_keytab.h"
#include "librpc/gen_ndr/ndr_drsblobs.h"
includes.h pulls in replace.h which defines all those PRIxxx things
before the system includes that get pulled in by smb_krb5.h.
It sure would remove a lot of useless noise warnings if we changed the
order of includes ...
--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)
More information about the samba-technical
mailing list