Can we include "includes" a little later?

Richard Sharpe realrichardsharpe at
Fri Dec 7 10:09:27 MST 2012

Hi folks,

In our build there are lots of instances of these warnings:

warning: "PRIi64" redefined
In file included from include/includes.h:23,
                 from libnet/libnet_dssync_keytab.c:21:
./../lib/replace/../replace/replace.h:91:1: warning: this is the
location of the previous definition
In file included from
                 from include/smb_krb5.h:36,
                 from libnet/libnet_dssync_keytab.c:22:

These come about because we include includes.h before smb_krb5.conf in

#include "includes.h"
#include "smb_krb5.h"
#include "ads.h"
#include "libnet/libnet_dssync.h"
#include "libnet/libnet_keytab.h"
#include "librpc/gen_ndr/ndr_drsblobs.h"

includes.h pulls in replace.h which defines all those PRIxxx things
before the system includes that get pulled in by smb_krb5.h.

It sure would remove a lot of useless noise warnings if we changed the
order of includes ...

Richard Sharpe

More information about the samba-technical mailing list