[PATCH] Clean up client timeout definitions [rev. 2]
jelmer at samba.org
Wed Dec 5 08:26:53 MST 2012
On Wed, 2012-12-05 at 10:17 -0500, Scott Lovenberg wrote:
> On Tue, Dec 4, 2012 at 8:26 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Tue, Dec 04, 2012 at 08:19:28PM -0500, simo wrote:
> >> On Tue, 2012-12-04 at 16:42 -0800, Jeremy Allison wrote:
> >> > On Tue, Dec 04, 2012 at 09:15:38AM -0500, scott.lovenberg at gmail.com wrote:
> >> > > From: Scott Lovenberg <scott.lovenberg at gmail.com>
> >> > >
> >> > > The definitions for default client timeout values have been moved to client.h. When initializing a client struct we use this value instead of the old hardcoded value. The timeout value remains 20 seconds.
> >> >
> >> > I hate to say it but SHORT_TIMEOUT actually isn't
> >> > used anywhere in the code that I can see, so it
> >> > actually can be removed.
> >> git agrees:
> >> $ git grep SHORT_TIMEOUT
> >> source3/client/client.c:#define SHORT_TIMEOUT (5*1000)
> > Yeah, that;'s how I checked but git doesn't always
> > tell the whole story - sometimes pidl autogenerated
> > code can use things it doesn't know about :-).
> > Jeremy.
> Eek. For future reference, is there any good way to check that I'm
> not going to stomp on autogenereated code?
Make sure you do a full build before submitting a patch. Presumably
you're doing that anyway.
More information about the samba-technical