[PATCH] Clean up client timeout definitions [rev. 2]

Scott Lovenberg scott.lovenberg at gmail.com
Wed Dec 5 08:14:44 MST 2012

On Tue, Dec 4, 2012 at 7:42 PM, Jeremy Allison <jra at samba.org> wrote:
> On Tue, Dec 04, 2012 at 09:15:38AM -0500, scott.lovenberg at gmail.com wrote:
>> From: Scott Lovenberg <scott.lovenberg at gmail.com>
>> The definitions for default client timeout values have been moved to client.h.  When initializing a client struct we use this value instead of the old hardcoded value.  The timeout value remains 20 seconds.
> I hate to say it but SHORT_TIMEOUT actually isn't
> used anywhere in the code that I can see, so it
> actually can be removed.

I noticed that.  I only did a quick grep of the source code for it, so
I wasn't confident enough to remove it on my first pass.  Ultimately
my goal here is to make client timeout an option (someone on the IRC
channel was asking for this), but this was a cleaning up pass before I
added that functionality.

> I'm ok with this patch, but I want to remove
> SHORT_TIMEOUT as well. Do you want to re-spin
> it, or are you happy with me pushing a version
> that just removes the SHORT_TIMEOUT definition
> (you keep credit on the author of course) ?
> Jeremy.

It's fine if you remove it and push. :)

Peace and Blessings,

More information about the samba-technical mailing list