Samba4rc6 compile fail on FreeBSD 9.1Release

[Andrew Bartlett]

On Wed, 2012-12-05 at 11:52 +1100, Dewayne wrote:
> Unfortunately the following sequence results in a failed build, using gcc on FreeBSD 9.1
> 
> S4KIT=samba-4.0.0rc6
> cd /tmp
> fetch http://ftp.samba.org/pub/samba/rc/${S4KIT}.tar.gz
> tar -xf ${S4KIT}.tar.gz
> cd $S4KIT
> ./configure --enable-debug --enable-selftest -j 2
> make 
> ... 
> 
> [3130/3789] Compiling source3/modules/vfs_zfsacl.c
> ../source3/modules/vfs_zfsacl.c: In function 'zfsacl_fget_nt_acl':
> ../source3/modules/vfs_zfsacl.c:205: warning: passing argument 2 of 'zfs_get_nt_acl_common' makes integer from pointer without a
> cast
> ../source3/modules/vfs_zfsacl.c:205: warning: passing argument 3 of 'zfs_get_nt_acl_common' makes pointer from integer without a
> cast
> ../source3/modules/vfs_zfsacl.c:205: error: too many arguments to function 'zfs_get_nt_acl_common'
> ../source3/modules/vfs_zfsacl.c:210: warning: passing argument 4 of 'smb_fget_nt_acl_nfs4' from incompatible pointer type
> ../source3/modules/vfs_zfsacl.c:210: error: too few arguments to function 'smb_fget_nt_acl_nfs4'
> ../source3/modules/vfs_zfsacl.c: At top level:
> ../source3/modules/vfs_zfsacl.c:307: warning: initialization from incompatible pointer type
> ../source3/modules/vfs_zfsacl.c:308: warning: initialization from incompatible pointer type
> Waf: Leaving directory `/data/samba-4.0.0rc6/bin'
> Build failed:  -> task failed (err #1):
>         {task: cc vfs_zfsacl.c -> vfs_zfsacl_35.o}
> *** [all] Error code 1
> 
> FYI: # diff samba-4.0.0rc5/source3/modules/vfs_zfsacl.c samba-4.0.0rc6/source3/modules/vfs_zfsacl.c
> 195,197c195,198
> <                                struct files_struct *fsp,
> <                                uint32 security_info,
> <                                struct security_descriptor **ppdesc)
> ---
> >                                  struct files_struct *fsp,
> >                                  uint32 security_info,
> >                                  TALLOC_CTX *mem_ctx,
> >                                  struct security_descriptor **ppdesc)
> 202c203,204
> <       status = zfs_get_nt_acl_common(fsp->fsp_name->base_name, security_info,
> ---
> >       status = zfs_get_nt_acl_common(fsp->fsp_name->base_name,
> >                                      mem_ctx, security_info,
> 212,213c214,216
> <                               const char *name,  uint32 security_info,
> <                               struct security_descriptor **ppdesc)
> ---
> >                                 const char *name, uint32 security_info,
> >                                 TALLOC_CTX *mem_ctx,
> >                                 struct security_descriptor **ppdesc)
> 223c226,227
> <       return smb_get_nt_acl_nfs4(handle->conn, name, security_info, ppdesc,
> ---
> >       return smb_get_nt_acl_nfs4(handle->conn, name, security_info,
> >                                  mem_ctx, ppdesc,
> 
> I'd removed a working rc5 to perform this test, so the platform is good.

Please provide patches as 'diff -u' format, or (even better) against our
git tree as 'git commit' and 'git format-patch -1'. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org