[PATCH] Clean up client timeout definitions [rev. 2]

simo idra at samba.org
Tue Dec 4 18:41:24 MST 2012


On Tue, 2012-12-04 at 17:26 -0800, Jeremy Allison wrote:
> On Tue, Dec 04, 2012 at 08:19:28PM -0500, simo wrote:
> > On Tue, 2012-12-04 at 16:42 -0800, Jeremy Allison wrote:
> > > On Tue, Dec 04, 2012 at 09:15:38AM -0500, scott.lovenberg at gmail.com wrote:
> > > > From: Scott Lovenberg <scott.lovenberg at gmail.com>
> > > > 
> > > > The definitions for default client timeout values have been moved to client.h.  When initializing a client struct we use this value instead of the old hardcoded value.  The timeout value remains 20 seconds.
> > > 
> > > I hate to say it but SHORT_TIMEOUT actually isn't
> > > used anywhere in the code that I can see, so it
> > > actually can be removed.
> > 
> > git agrees:
> > 
> > $ git grep SHORT_TIMEOUT
> > source3/client/client.c:#define SHORT_TIMEOUT (5*1000)
> 
> Yeah, that;'s how I checked but git doesn't always
> tell the whole story - sometimes pidl autogenerated
> code can use things it doesn't know about :-).

True, sad but true, sometimes make you wish we'd commit autogenerated
code again...

Simo.


-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list