BUILD_FARM_HACKS and vfs_aio_fork

[Andrew Bartlett]

On Tue, 2012-08-21 at 11:32 +0200, Volker Lendecke wrote:
> On Tue, Aug 21, 2012 at 06:47:28PM +1000, Andrew Bartlett wrote:
> > On Tue, 2012-08-21 at 09:52 +0200, Volker Lendecke wrote:
> > > On Tue, Aug 21, 2012 at 01:19:30PM +1000, Andrew Bartlett wrote:
> > > > I would appreciate to know your thoughts.
> > > 
> > > In the past, I have made it a #define due to speed concerns.
> > > But as aio_fork is pretty heavy-weight anyway, a flag in the
> > > VFS handle (similar to what the GPFS module does) evaluated
> > > at connect() time and queried on every async read and write
> > > might be appropriate here.
> > 
> > That should be quite practical to implement (been doing VFS stuff a lot
> > recently it seems!).  To automatically test it, will it be enough to add
> > an additional share using vfs_aio_fork and run (say) RW1 against it with
> > 'aio read size = 1' and 'aio write size = 1'?  Is there anything else I
> > should know?
> 
> That should be it I think. With the "new" python code more
> tests torturing that a bit more are easier to write than
> with tevent_req, but that is probably something for later.

Thanks,

For now, at least the code is tested, which should help avoid accidental
breakage.  Those tests are now in master. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org