[PATCHES] Improve output of wbinfo --ping-dc

[Andrew Bartlett]

On Tue, 2012-08-14 at 15:33 -0600, Christof Schmitt wrote:
> Andrew Bartlett <abartlet at samba.org> wrote on 08/10/2012 11:51:55 PM:
> 
> > The autobuild with this failed.  Did these pass a full make test for
> > you?
> > 
> > I got:
> > 
> > UNEXPECTED(failure): samba3.winbind.wbclient.wbcPingDc(s3dc)
> > REASON: _StringException: _StringException: 
> ../nsswitch/libwbclient/tests/
> > wbclient.c:61: wbcPingDc(((void *)0), ((void *)0)) was 
> > WBC_ERR_WINBIND_NOT_AVAILABLE, expected WBC_ERR_SUCCESS: wbcPingDc 
> failed
> > 
> > The test code here is in nsswitch/libwbclient/tests/wbclient.c.  Please
> > also extend it to cover your new code.
> 
> Sorry, i missed the fact that the internal domain does not report the
> DC. I added additional checks for the case when the name is not
> available. The last patch adds a test for the new wbcPingDc2 function,
> but since the DC name is not available i could only duplicate the
> tests from wbcPingDc.
> 
> The samba3.winbind test now passes:
> 
> [1/4 in 0s] samba3.winbind.struct(s3dc)
> [2/4 in 13s] samba3.winbind.struct(plugin_s4_dc)
> [3/4 in 13s] samba3.winbind.wbclient(s3dc)
> [4/4 in 16s] samba3.winbind.wbclient(plugin_s4_dc)
> smbd child process 18118 exited with value 0
> nmbd child process 18114 exited with value 0
> winbindd child process 18116 exited with value 0

With an extra knownfail entry for plugin_s4_dc (please run make test
with the waf build to cover all of Samba) this got into master
yesterday.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org