[PATCHES] Improve output of wbinfo --ping-dc

[Christof Schmitt]

Andrew Bartlett <abartlet at samba.org> wrote on 08/10/2012 11:51:55 PM:

> The autobuild with this failed.  Did these pass a full make test for
> you?
> 
> I got:
> 
> UNEXPECTED(failure): samba3.winbind.wbclient.wbcPingDc(s3dc)
> REASON: _StringException: _StringException: 
../nsswitch/libwbclient/tests/
> wbclient.c:61: wbcPingDc(((void *)0), ((void *)0)) was 
> WBC_ERR_WINBIND_NOT_AVAILABLE, expected WBC_ERR_SUCCESS: wbcPingDc 
failed
> 
> The test code here is in nsswitch/libwbclient/tests/wbclient.c.  Please
> also extend it to cover your new code.

Sorry, i missed the fact that the internal domain does not report the
DC. I added additional checks for the case when the name is not
available. The last patch adds a test for the new wbcPingDc2 function,
but since the DC name is not available i could only duplicate the
tests from wbcPingDc.

The samba3.winbind test now passes:

[1/4 in 0s] samba3.winbind.struct(s3dc)
[2/4 in 13s] samba3.winbind.struct(plugin_s4_dc)
[3/4 in 13s] samba3.winbind.wbclient(s3dc)
[4/4 in 16s] samba3.winbind.wbclient(plugin_s4_dc)
smbd child process 18118 exited with value 0
nmbd child process 18114 exited with value 0
winbindd child process 18116 exited with value 0

ALL OK (40 tests in 2 testsuites)

Regards,

Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
christof.schmitt at us.ibm.com  ||  +1-520-799-2469  (T/L: 321-2469)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-winbind-Pass-ping-dc-result-to-client.patch
Type: application/octet-stream
Size: 1572 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120814/c6dabfde/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-winbind-Return-the-DC-name-from-DC_PING.patch
Type: application/octet-stream
Size: 2541 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120814/c6dabfde/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-libwbclient-Add-wbcPingDc2.patch
Type: application/octet-stream
Size: 9230 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120814/c6dabfde/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-wbinfo-Improve-output-of-wbinfo-ping-dc.patch
Type: application/octet-stream
Size: 1686 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120814/c6dabfde/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-libwbclient-Add-test-for-wbcPingDc2.patch
Type: application/octet-stream
Size: 1766 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120814/c6dabfde/attachment-0004.obj>