[PATCH] Redefine smb_acl_t in IDL and use talloc

Andrew Bartlett abartlet at samba.org
Sun Aug 12 16:08:33 MDT 2012


This patch moves the declaration of smb_acl_t to IDL and changes the
allocation code to use talloc.

https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/posix-acl-provision-wip

The reason I'm doing this is that I want to have some tests on and
confidence with the NT -> posix ACL conversions, particularly as I have
had some patches changing behaviour here accepted.

The issue is that doing this as non-root has issues, so I want to
emulate the whole ACL and ownership store by putting it on an xattr (and
in turn in a tdb). 

To do this, I need to be able to marshal an smb_acl_t.  In turn, I
should be able to parse it with python, which will help a lot with
validating results.

It also means we can (later, or sooner if you request) take the step of
enrolling the objects into the talloc tree correctly. 

Please carefully review this, and see what you think.  

It passes a full manual autobuild on sn-devel.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-Change-allocation-of-smb_acl_t-to-talloc.patch
Type: text/x-patch
Size: 11057 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120813/0fbbba04/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-pidl-Add-mode_t-as-an-alias-so-we-can-marshall-posix.patch
Type: text/x-patch
Size: 692 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120813/0fbbba04/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s3-smbd-Move-smb_acl_t-declaration-to-smb_acl.idl.patch
Type: text/x-patch
Size: 5790 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120813/0fbbba04/attachment-0002.bin>


More information about the samba-technical mailing list