[PATCHES] Improve output of wbinfo --ping-dc

[Andrew Bartlett]

On Sat, 2012-08-11 at 14:41 +1000, Andrew Bartlett wrote:
> On Fri, 2012-08-10 at 16:52 -0600, Christof Schmitt wrote:
> > Andrew Bartlett <abartlet at samba.org> wrote on 08/10/2012 02:52:24 PM:
> > > On Fri, 2012-08-10 at 10:31 -0600, Christof Schmitt wrote:
> > > > Here is an updated version of the patches. They now introduce a new
> > > > function wbcPingDc2 with an extra argument to return the DC name.
> > > 
> > > This looks good, except you can't change the ABI file like that. 
> > > 
> > > Instead, you have to change the version in nsswitch/libwbclient/wscript
> > > and nsswitch/libwbclient/wbclient.h to 0.10, then add
> > > nsswitch/libwbclient/ABI/wbclient.0.10.sigs to git.
> > > 
> > > This records what the ABI was for 0.9 (which is then used for the
> > > version scripts), and then again for the new 0.10.
> > > 
> > > (It's an annoying detail I could 'just' fix, but I figure it is worth
> > > explaining how the ABI stuff works).
> > 
> > Thanks for explaining that, i was not entirely sure where to add the
> > new signature. Here is the next update of the patches, it introduces
> > the new ABI file and also updates the version defines in wbclient.h to
> > 0.10.
> 
> Thanks.  I'm autobuilding those now.

The autobuild with this failed.  Did these pass a full make test for
you?

I got:

UNEXPECTED(failure): samba3.winbind.wbclient.wbcPingDc(s3dc)
REASON: _StringException: _StringException: ../nsswitch/libwbclient/tests/wbclient.c:61: wbcPingDc(((void *)0), ((void *)0)) was WBC_ERR_WINBIND_NOT_AVAILABLE, expected WBC_ERR_SUCCESS: wbcPingDc failed

The test code here is in nsswitch/libwbclient/tests/wbclient.c.  Please
also extend it to cover your new code.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org