[PATCHES] Improve output of wbinfo --ping-dc

Christof Schmitt christof.schmitt at us.ibm.com
Fri Aug 10 16:52:11 MDT 2012


Andrew Bartlett <abartlet at samba.org> wrote on 08/10/2012 02:52:24 PM:
> On Fri, 2012-08-10 at 10:31 -0600, Christof Schmitt wrote:
> > Here is an updated version of the patches. They now introduce a new
> > function wbcPingDc2 with an extra argument to return the DC name.
> 
> This looks good, except you can't change the ABI file like that. 
> 
> Instead, you have to change the version in nsswitch/libwbclient/wscript
> and nsswitch/libwbclient/wbclient.h to 0.10, then add
> nsswitch/libwbclient/ABI/wbclient.0.10.sigs to git.
> 
> This records what the ABI was for 0.9 (which is then used for the
> version scripts), and then again for the new 0.10.
> 
> (It's an annoying detail I could 'just' fix, but I figure it is worth
> explaining how the ABI stuff works).

Thanks for explaining that, i was not entirely sure where to add the
new signature. Here is the next update of the patches, it introduces
the new ABI file and also updates the version defines in wbclient.h to
0.10.

Regards,

Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
christof.schmitt at us.ibm.com  ||  +1-520-799-2469  (T/L: 321-2469)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-winbind-Pass-ping-dc-result-to-client.patch
Type: application/octet-stream
Size: 1572 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/b27003cb/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-winbind-Return-the-DC-name-from-DC_PING.patch
Type: application/octet-stream
Size: 2540 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/b27003cb/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-libwbclient-Add-wbcPingDc2.patch
Type: application/octet-stream
Size: 9202 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/b27003cb/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-wbinfo-Improve-output-of-wbinfo-ping-dc.patch
Type: application/octet-stream
Size: 1686 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120810/b27003cb/attachment-0003.obj>


More information about the samba-technical mailing list