debug prints - new suggested patch

Andrew Bartlett abartlet at samba.org
Wed Aug 8 16:32:11 MDT 2012


On Wed, 2012-08-08 at 12:26 -0700, Herb Lewis wrote:
> OK, I added Andrew's suggestion and printed the header if we are
> using stdout, and made some more changes. Comments welcome.
> 
> My previous change broke the feature of indenting non-header lines so I
> added the SOH character to the beginning of the header lines so we can
> tell it is a header. This is then not printed in format_debug_text but lines
> that do not start with this special character are indented if in timestamp
> mode.
> 
> When "debug pid = yes" is set, (which only takes affect if one of the 
> timestamp
> parameters is also set) then the non-header lines begin with the the
> "[pid=xxxx] " string so you can tell which smbd the message belongs to
> when you are not sending output to separate files.

Looks good.  Let's get this into the tree and work on any more oddities
there.  (I think we will have a much better feeling for them once we are
working with them daily). 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list