[PATCH] Convert s3 loadparm to use talloc for parameter strings

[Andrew Bartlett]

Rusty,

I've been working on your branch that uses talloc for strings in
loadparm.

Based on your last (failed) autobuild, I've got in the preparatory
patches in autobuild now, and the rest are at:

https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/fix-param-talloc

As the large 'conversion' patch seems to be having trouble, I think we
probably need a preparatory patch that makes string_set() and
string_free() call lpcfg_string_set() and TALLOC_FREE().  Then we can
remove the wrapper (in multiple commits).  This may help us find where
the issues are.

Hopefully between us we can finish this conversion.  Thank you very much
for your efforts so far.

In my work so far, I've found a number of small but important issues
with the conversion.  I've now got nmbd starting (the issue was the
mis-handling of parametric options) and fixed the segfaults due to using
stack structures as talloc pointers, but tree connections on smbd still
fail.  

This task does highlight the challenge of retrofitting talloc onto an
existing codebase, but I'm sure we can get this sorted soon.

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org