[PATCH] A merged set of smb.conf parameters!

Andrew Bartlett abartlet at samba.org
Fri Aug 3 22:39:29 MDT 2012


On Fri, 2012-08-03 at 18:06 +0200, Christian Ambach wrote:
> On 07/27/2012 04:20 AM, Andrew Bartlett wrote:
> 
> > In general, where it does not create crazy header dependencies, it makes
> > sense to have the defines where the code the parameter is for is
> > located.
> 
> Most of the param code has the enums it used sitting right next to it,
> so why not do that for all parameters? Will make it easier to look out 
> for them.
> 
> > Now, I realise this is in direct contradiction to the patch I just
> > merged.  Some of those could probably be put back, if we can get them
> > into 'clean' headers that include without major dependencies.
> 
> I think your patches put them into the right spot, let's not move them 
> back. I would push the attached patch to move the DNS update enum next 
> to others next week if there are no objections.
> 
> > The distinction between 'common code', source3 and source4 is being
> > eroded anyway, so I don't place a very high value on keeping that
> > distinction.
> 
> That's unfortunate, because the distinction makes it possible to 
> recognize and avoid circular dependencies. So I would suggest to keep it 
> up as far as possible.

These are all very reasonable arguments.  Thanks for thinking so
carefully about this.  I'm happy with the change.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list