When we retrieve the ACL for a file we should cache it in the FSP to avoid retrieving it multiple times ...

Jeremy Allison jra at samba.org
Thu Apr 26 21:48:55 MDT 2012

On Thu, Apr 26, 2012 at 07:58:53PM -0700, Richard Sharpe wrote:
> Hi,
> I have noticed that when handling NTCreate&X, for example, we retrieve
> the ACL multiple times.
> It would seem better, perhaps, to cache the ACL in the FSP rather than
> retrieving it multiple times.
> This seems to be because in several places we call
> can_delete_file_in_directory or can_write_to_file in a variety of
> places, including where we already have an FSP and actually know that
> access_granted ...
> It would seem that we can do better, although I know that people have
> been busy recently :-)

Yes, I did consider this, we can do better :-). The original layering
of the VFS made this quite hard, but now the access control is centralized
it should be much easier to make this change.


More information about the samba-technical mailing list