waf: Add possibility to build with system libwbclient/libsmbclient

[Andrew Bartlett]

On Fri, 2012-04-20 at 14:45 +0200, Andreas Schneider wrote:
> On Friday 20 April 2012 22:33:39 Andrew Bartlett wrote:
> > On Fri, 2012-04-20 at 11:07 +0200, Andreas Schneider wrote:
> > > On Friday 20 April 2012 12:02:17 Andrew Bartlett wrote:
> > > > A corrected version of this patch is now in the tree.  Please let me
> > > > know if this would allow us to then remove the ability to use the system
> > > > library versions of libsmbclient and libwbclient.
> > > 
> > > I've created packages with
> > > 
> > > --private-libraries=smbclient,wbclient
> > > 
> > > but the libraries are still in /usr/lib64/ and not in /usr/lib64/samba so
> > > they conflict with samba3 libraries.
> > 
> > Could these be the old libraries somehow?
> > 
> > I just did a build with:
> > ./configure --prefix=/tmp/samba-prefix
> > --private-libraries=smbclient,wbclient
> > 
> > this is what I got:
> > 
> > [abartlet at obed samba-2]$ find /tmp/samba-prefix/ -name *wbclient*
> > /tmp/samba-prefix/include/wbclient.h
> > /tmp/samba-prefix/lib/private/libwbclient.so.0
> > /tmp/samba-prefix/lib/private/libwbclient.so.0.9
> > 
> > Then I tried:
> > ./configure.developer --enable-fhs --prefix=/tmp/samba-prefix-fhs
> > --private-libraries=smbclient,wbclient
> > 
> > [abartlet at obed samba-2]$ find /tmp/samba-prefix-fhs/ -name *wbclient*
> > /tmp/samba-prefix-fhs/include/samba-4.0/wbclient.h
> > /tmp/samba-prefix-fhs/lib/samba/libwbclient.so.0
> > /tmp/samba-prefix-fhs/lib/samba/libwbclient.so.0.9
> > 
> > So, I'm just a bit puzzled, as it seems to work for me.
> 
> Sorry, I think this was a false alarm. Somehow the build system didn't pick up 
> the changes and built without --private-libraries.
> 
> I'm doing new builds right now. If they are fine we can remove the linking 
> against system libwbclient and system libsmbclient.

How did the builds go?

Attached is my proposed patch to remove the system libwbclient and
system libsmbclient options.

Thanks, 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-Remove-support-for-system-libwbclient.patch
Type: text/x-patch
Size: 2580 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120423/b54e14f0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-build-Remove-support-for-a-system-libsmbclient.patch
Type: text/x-patch
Size: 1830 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120423/b54e14f0/attachment-0001.bin>