examples/VFS/Makefile.in in master seems well out of date ...

[Richard Sharpe]

On Sun, Apr 15, 2012 at 3:33 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> On Sat, 2012-04-14 at 13:35 -0700, Richard Sharpe wrote:
>> Hi Folks,
>>
>> I noticed that the Makefile.in for the examples/VFS directory is not
>> as good as that in Samba V3-6-test ...
>>
>> The main problem is that the one in master only knows about
>> skel_transparent and skel_opaque, where as the one in v3-6-test knows
>> about any .c file in that directory. If there are no objections, I
>> will fix that little problem.
>>
>> --- ../samba.master/examples/VFS/Makefile.in  2012-03-23 21:28:05.567749945 -0
>> 700
>> +++ ../samba.3-6/examples/VFS/Makefile.in     2012-03-24 12:04:36.109708432 -0
>> 700
>> @@ -9,7 +9,6 @@
>>  OBJEXT               = @OBJEXT@
>>  FLAGS                =  $(CFLAGS) $(CPPFLAGS) -fPIC \
>>               -Iinclude -I$(SAMBA_SOURCE)/include \
>> -             -I$(SAMBA_SOURCE)/include/autoconf \
>>               -I$(SAMBA_SOURCE)/../popt  \
>>               -I$(SAMBA_SOURCE)/../lib/replace  \
>>               -I$(SAMBA_SOURCE)/../lib/talloc  \
>> @@ -26,26 +25,18 @@
>
> Just a comment on the first chunk for background.
>
> The -I$(SAMBA_SOURCE)/include/autoconf is required to find config.h,
> which is placed in a different directory to make the recursive build of
> smbtorture4 more reliable, so that waf doesn't see config.h from
> autoconf (autoconf already doesn't see the waf one in
> bin/default/include/config.h)

Actually, that was an artifact of my comparing v3-6-test with master.

> Also, for 4.0, it looks like this example system won't really help build
> modules for the waf build.  These would need to be built in-tree for
> now.

Surely we would only need a wscript wouldn't we?

Hmmm, building outside the tree with make would still work as long as
we have access to config.h unless even that is removed in the waf
build ...

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)