examples/VFS/Makefile.in in master seems well out of date ...

Richard Sharpe realrichardsharpe at gmail.com
Sun Apr 15 13:55:52 MDT 2012

On Sun, Apr 15, 2012 at 12:28 PM, Richard Sharpe
<realrichardsharpe at gmail.com> wrote:
> On Sun, Apr 15, 2012 at 12:19 AM, Volker Lendecke
> <Volker.Lendecke at sernet.de> wrote:
>> On Sat, Apr 14, 2012 at 01:35:52PM -0700, Richard Sharpe wrote:
>>> I noticed that the Makefile.in for the examples/VFS directory is not
>>> as good as that in Samba V3-6-test ...
>>> The main problem is that the one in master only knows about
>>> skel_transparent and skel_opaque, where as the one in v3-6-test knows
>>> about any .c file in that directory. If there are no objections, I
>>> will fix that little problem.
>> Have you seen bc6803febb90d8a22271b5976403cf3e1c36192b ? Can
>> you make it so that it works with FreeBSD make as well?
> I hadn't, but I have now. Thanks.
> I think a solution might be to have a Makefile and a Makefile.linux
> and a Makefile.FreeBSD and a Makefile.simple and have Makefile
> recursively call the appropriate one.
> The problem, it seems to me is that those who want to do out-of-tree
> modules are not served at all by the existing Makefile because they
> typically have no idea of what changes are needed.
> I believe that I can come up with an equivalent FreeBSD make file.
> However, it will take a little while :-) I will need to install a
> FreeBSD VM.
> Of course, some one with FreeBSD make skills could chime in.

OK, a better proposal.

This, for example:

skel_opaque. at SHLIBEXT@: skel_opaque. at OBJEXT@
       @echo "Linking $@"
       @$(CC) $(LDSHFLAGS) $(LDFLAGS) skel_opaque. at OBJEXT@ -o $@

shadow_copy_test. at SHLIBEXT@: shadow_copy_test. at OBJEXT@
       @echo "Linking $@"
       @$(CC) $(LDSHFLAGS) $(LDFLAGS) shadow_copy_test. at OBJEXT@ -o $@

skel_transparent. at SHLIBEXT@: skel_transparent. at OBJEXT@
        @echo "Linking $@"
       @$(CC) $(LDSHFLAGS) $(LDFLAGS) skel_transparent. at OBJEXT@ -o $@

could possibly be replaced with:

        @echo "Linking $<"
         @$(CC) $(LDSHFLAGS) $(LDFLAGS) $< -o $@

Which would leave us with the definition of the things to be built in
only one place ... and would make it clearer as to what need to be

I will try that out to see if it works.

Richard Sharpe

More information about the samba-technical mailing list