examples/VFS/Makefile.in in master seems well out of date ...

Richard Sharpe realrichardsharpe at gmail.com
Sat Apr 14 14:35:52 MDT 2012


Hi Folks,

I noticed that the Makefile.in for the examples/VFS directory is not
as good as that in Samba V3-6-test ...

The main problem is that the one in master only knows about
skel_transparent and skel_opaque, where as the one in v3-6-test knows
about any .c file in that directory. If there are no objections, I
will fix that little problem.

--- ../samba.master/examples/VFS/Makefile.in	2012-03-23 21:28:05.567749945 -0
700
+++ ../samba.3-6/examples/VFS/Makefile.in	2012-03-24 12:04:36.109708432 -0
700
@@ -9,7 +9,6 @@
 OBJEXT		= @OBJEXT@
 FLAGS		=  $(CFLAGS) $(CPPFLAGS) -fPIC \
 		-Iinclude -I$(SAMBA_SOURCE)/include \
-		-I$(SAMBA_SOURCE)/include/autoconf \
 		-I$(SAMBA_SOURCE)/../popt  \
 		-I$(SAMBA_SOURCE)/../lib/replace  \
 		-I$(SAMBA_SOURCE)/../lib/talloc  \
@@ -26,26 +25,18 @@

 VFS_LIBDIR	= $(libdir)/vfs

-all: skel_opaque. at SHLIBEXT@ shadow_copy_test. at SHLIBEXT@ \
-	skel_transparent. at SHLIBEXT@
+# Auto target
+default: $(patsubst %.c,%.$(SHLIBEXT),$(wildcard *.c))

-skel_opaque. at SHLIBEXT@: skel_opaque. at OBJEXT@
-	@echo "Linking $@"
-	@$(CC) $(LDSHFLAGS) $(LDFLAGS) skel_opaque. at OBJEXT@ -o $@
-
-shadow_copy_test. at SHLIBEXT@: shadow_copy_test. at OBJEXT@
-	@echo "Linking $@"
-	@$(CC) $(LDSHFLAGS) $(LDFLAGS) shadow_copy_test. at OBJEXT@ -o $@
+# Pattern rules

-skel_transparent. at SHLIBEXT@: skel_transparent. at OBJEXT@
+%.$(SHLIBEXT): %.$(OBJEXT)
 	@echo "Linking $@"
-	@$(CC) $(LDSHFLAGS) $(LDFLAGS) skel_transparent. at OBJEXT@ -o $@
-
-# Pattern rules
+	@$(CC) $(LDSHFLAGS) $(LDFLAGS) -o $@ $<

-.c. at OBJEXT@:
+%.$(OBJEXT): %.c
 	@echo "Compiling $<"
-	@$(CC) $(FLAGS) -c $< -D$*_init=samba_init_module
+	@$(CC) $(FLAGS) -c $< -D$*_init=init_samba_module


 install: default


-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list