Recent kerberos refactoring
jelmer at samba.org
Thu Apr 12 08:11:16 MDT 2012
Am 12/04/12 16:02, schrieb Alexander Bokovoy:
> On Thu, Apr 12, 2012 at 16:54, Jelmer Vernooij <jelmer at samba.org> wrote:
>> Hi Alexander, Andreas,
>> This breaks the build against system Heimdal:
>> charis:~/src/samba% make
>> WAF_MAKE=1 ./buildtools/bin/waf build
>> Waf: Entering directory `/home/jelmer/src/samba.git1/bin'
>> Checking project rules ...
>> Unknown dependency 'k5crypto' in 'addns'
> This needs to be fixed, yes.
What do you mean exactly, are you working on fixing that regression?
>> Wouldn't it make more sense to just conditionally add build files,
>> rather than allowing the rest of them to be skipped halfway through? The
>> nice thing about if statements is that it's fairly clear that something
>> is conditional; having an exception being raised halfway through the
>> file makes it unobvious what is going exactly without reading the file
>> all the way from the beginning.
> If you do conditionals, whole git history for those wscripts will be
> overridden with formatting changes for nothing.
> Practically, whole heimdal wscripts will have to be if-ed and I'm not
> really ready for doing those indents just for such purpose.
I'm not suggesting indenting everything, but rather to have a separate
wscript file and optionally using that. I imagine we could just have
three different files for kerberos - one for the bundled heimdal, one
for system Heimdal and one for system MIT.
> Making an exception and properly catching it is way better. We can add
> more verbose output telling why processing stopped and at which line.
It will require reading the entire wscript file if it turns out some command in it doesn't get executed. I'm worried this will lead to headaches when debugging, or when simply adding a new line to the bottom of the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 900 bytes
Desc: OpenPGP digital signature
More information about the samba-technical