Recent kerberos refactoring

[Jelmer Vernooij]

Hi Alexander, Andreas,

This breaks the build against system Heimdal:

charis:~/src/samba% make
WAF_MAKE=1 ./buildtools/bin/waf build
Waf: Entering directory `/home/jelmer/src/samba.git1/bin'
Checking project rules ...
Unknown dependency 'k5crypto' in 'addns'


Am 12/04/12 15:24, schrieb Andreas Schneider:
> - Log -----------------------------------------------------------------
> commit bcc16f191175740f200c12925b63d45478f06454
> Author: Alexander Bokovoy <ab at samba.org>
> Date:   Tue Apr 10 12:09:20 2012 +0300
>
>     s4-libnet: split export_keytab in a separate python module to avoid pulling in HDB dependency
>     
>     Signed-off-by: Andreas Schneider <asn at samba.org>
>     
>     Autobuild-User: Andreas Schneider <asn at cryptomilk.org>
>     Autobuild-Date: Thu Apr 12 15:23:19 CEST 2012 on sn-devel-104
Cool, that's really nice!




> commit dda0531aae70e78e815fda8c594213369e76a847
> Author: Alexander Bokovoy <ab at samba.org>
> Date:   Tue Apr 3 11:22:15 2012 +0300
>
>     WAF: Add support for stopping processing before end of wscript{_*}
>     
>     WAF scripts are written in Python and Python has no simple way
>     to stop program execution other than using exceptions.
>     
>     This change adds WscriptCheckSkipped exception and its handling in
>     core WAF code. When any of wscript{_*} throws WscriptCheckSkipped
>     exception, WAF simply continues to process next wscript in queue
>     rather than breaking build.
>     
>     WscriptCheckSkipped exception can be used to perform early bail out
>     of configuration/build target checks if certain dependency is not available
>     when the default checks are way more numerous than a check for this
>     particular dependency. This is to avoid 'if ...' indenting for large
>     blocks of existing code which also muddens git history for nothing.
>     
>     Signed-off-by: Andreas Schneider <asn at samba.org>
Is this one really necessary? It doesn't actually seem to be used
anywhere yet.

Wouldn't it make more sense to just conditionally add build files,
rather than allowing the rest of them to be skipped halfway through? The
nice thing about if statements is that it's fairly clear that something
is conditional; having an exception being raised halfway through the
file makes it unobvious what is going exactly without reading the file
all the way from the beginning.

Cheers,

Jelmer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120412/8d85c2e7/attachment.pgp>