[PATCH] Try to reduce ccan packaging pain
abartlet at samba.org
Mon Apr 9 04:15:27 MDT 2012
On Mon, 2012-04-09 at 10:53 +0200, Jelmer Vernooij wrote:
> Am 05/04/12 08:08, schrieb Andrew Bartlett:
> > I've been told that the issues with bundled ccan libs are still causing
> > issues for distributors, so I've come up with a patch that I think
> > should help. I'm doing this so we can separate these issues from any
> > other discussion around tdb2, as I think there are technical build
> > system issues we can address.
> > These patches re-introduce the private library extension (-samba4, -ldb,
> > etc), but only for ccan. This is on the basis (which I need to confirm)
> > that ccan has no static data that would cause an issue if duplicated.
> > Libraries with important static data like talloc are not renamed, and
> > will deliberately cause a library conflict as pre previous behaviour.
> > (BTW, Linux distributors should not bundle or distribute libreplace, but
> > instead depend on libbsd).
> > Please let me know if this helps. The patches are attached, and in
> > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/less-ccan-pain
> This seems to have roughly the same effect as building ccan as a
> built-in library. What is the advantage of building ccan as private
> library with suffix rather than a built-in library? We still end up with
> a new copy for each project that uses it.
Correct. I wasn't trying to fix the policy part of the problem, just
the technical part that having ccan built in seemed to be causing
trouble, and having it as a private lib caused issues with duplication
of so name.
But as I didn't have a great definition for the original non-policy
problem, it was just a stab in the dark.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical