[PATCH] s3-smbd: move print_backend_init() behind init_system_info()

Ralph Wuerthner ralphw at de.ibm.com
Thu Apr 5 09:54:41 MDT 2012


On Thu, 05 Apr 2012 13:52:18 +1000
Andrew Bartlett <abartlet at samba.org> wrote:

> On Wed, 2012-04-04 at 18:33 +0200, Ralph Wuerthner wrote:
> > We noticed in Samba 3.6.3 the following error messages during smbd
> > startup:
> > 
> > [2012/04/04 16:29:50.511526,  0]
> > printing/nt_printing_ads.c:360(check_published_printers)
> > check_published_printers: Could not create system session_info
> > [2012/04/04 16:29:50.512101,  0]
> > printing/nt_printing.c:102(nt_printing_init) nt_printing_init:
> > error checking published printers: WERR_ACCESS_DENIED
> > 
> > It turned out that commit 62a2a9 "s3-smbd: Regroup some init
> > functions." by Andreas Schneider <asn at samba.org> caused theses
> > error messages.
> > 
> > I wrote the patch below to reorder print_backend_init() behind
> > init_system_info(). Is this working as expected or does it cause a
> > catastrophic malfunction in Samba?
> 
> This sounds reasonable to me.  init_system_info() needs to be one of
> the first calls made at startup.  
> 
> Other work seems to have resolved the call order in master, so for 3.6
> you will need to file this in bugzilla for approval. 

Ok, I opened bugzilla 8845 "check_published_printers: Could not create
system session_info".

Regards

   Ralph



More information about the samba-technical mailing list