[PATCH] Remove unused lgetxattr support from smbd

Björn JACKE bj at SerNet.DE
Mon Apr 2 06:51:44 MDT 2012

On 2012-04-02 at 13:18 +1000 Andrew Bartlett sent off:
> I was reviewing our xattr vfs stack in preparation for supporting the
> posix:eadb format of xattr-in-a-tdb in smbd.  
> This led me to check if I needed to implement all the calls, and a grep
> and subsequent patches indicates that lgetxattr isn't called anywhere.
> The attached patch removes this unused code. 
> Can anyone think of a reason why we should keep this?  (I'm not really
> bothered either way, but just wanted to reduce complexity before I
> started my implementation work). 

I think linux does not support EAs or ACLs on symlinks but afaik *BSD systems
do. So it would be nice if we'd be able to support this via unix extensions,
then we would need them.  But as now we don't have that function in use
currently, then it seems currently safe to remove the symlink related


More information about the samba-technical mailing list