[PATCH] Remove unused lgetxattr support from smbd

Andrew Bartlett abartlet at samba.org
Sun Apr 1 22:19:40 MDT 2012


On Mon, 2012-04-02 at 13:18 +1000, Andrew Bartlett wrote:
> I was reviewing our xattr vfs stack in preparation for supporting the
> posix:eadb format of xattr-in-a-tdb in smbd.  
> 
> This led me to check if I needed to implement all the calls, and a grep
> and subsequent patches indicates that lgetxattr isn't called anywhere.
> The attached patch removes this unused code. 
> 
> Can anyone think of a reason why we should keep this?  (I'm not really
> bothered either way, but just wanted to reduce complexity before I
> started my implementation work). 

BTW, the same would seem to apply to llistxattr.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list