[SCM] Samba Shared Repository - branch master updated

Richard Sharpe realrichardsharpe at gmail.com
Sun Apr 1 10:45:38 MDT 2012


On Sun, Apr 1, 2012 at 7:40 AM, Jelmer Vernooij <jelmer at samba.org> wrote:
>> + status = smb_raw_open(spdata->tree, self->talloc_ctx, &io);
>> + PyErr_NTSTATUS_IS_ERR_RAISE(status);
> Are you sure you want to use self->talloc_ctx in this case?
> self->talloc_ctx doesn't get destroyed until the SMB object is
> destroyed, which means that you keep allocating more memory even when
> files are closed, until the SMB object is garbage collected.

It seems like I can just establish a new talloc context and then clean
up that memory when the call returns ...

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list