s4: "findprovisionusnranges" helper

Matthias Dieter Wallnöfer mdw at samba.org
Fri Sep 30 14:01:08 MDT 2011


Andrew Bartlett wrote:
> On Fri, 2011-09-30 at 17:39 +0200, Matthias Dieter Wallnöfer wrote:
>> Hi ekacnet,
>>
>> after looking at bug report #8504
>> (https://bugzilla.samba.org/show_bug.cgi?id=8504) I stumbled over
>> "scripting/bin/findprovisionusnranges" which acts as helper for several
>> other python scripts ("provision", "upgradeprovision", "samba-tool
>> dbcheck") but at the moment doesn't get installed.
>> To fix this for "samba-tool dbcheck" which should be runnable after
>> installation we could patch like this:
>> http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=commitdiff;h=937ad0021266b156c72d842d81447b2d322bff26
>> or, as Jelmer proposed on the patch review, convert it to a python
>> module. What's your opinion?
> Firstly, I think this is mistaken.  I can't see how dbcheck calls this,
> - have you or the reporter confused dbcheck with upgradeprovision?
Most probably you are true. But the next problem lies in the fact that 
"upgradeprovision" does get installed under <repo path>/bin since there 
exists a rule "bld.SAMBA_SCRIPT('upgradeprovision', 
pattern='upgradeprovision', installdir='.')" in "wscript_build" under 
"source4/scripting/bin". So people might call it from there and don't 
find "findprovisionusnranges". What to do here?

Matthias


More information about the samba-technical mailing list