[PATCH] Remove fstrngs from GROUP_MAP

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Sep 28 08:57:48 MDT 2011


On Wed, Sep 28, 2011 at 10:46:34AM -0400, simo wrote:
> On Wed, 2011-09-28 at 16:42 +0200, Volker Lendecke wrote: 
> > On Wed, Sep 28, 2011 at 10:40:09AM -0400, simo wrote:
> > > Make test does involve samr operations, in fact I discovered a few bugs
> > > through make test during development.
> > 
> > Yes, I am aware that make test does involve samr operations.
> > 
> > > I do not have a PDC with LDAP handy at the moment, but the LDAP side has
> > > seen minimal change and all quite obvious so I think the tests we see in
> > > make test may be enough to cover that part.
> > 
> > If you are really, really certain that you did not break the
> > LDAP side of things then this might be okay. I still feel
> > very uneasy, but this might be just me.
> 
> I will see if I can find time to do an actual smoke gun test on it.
> Would that be enough ?

Sure. Set up an LDAP PDC with editposix and play back and
forth either usrmgr if it's still available or do some
groups operations with net rpc. That would be fine for me.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen


More information about the samba-technical mailing list