modules/vfs_default.c:vfswrap_is_offline uses talloc_tos ...

Richard Sharpe realrichardsharpe at gmail.com
Sun Sep 25 16:39:18 MDT 2011


Hi,

In the function source3/modules/vfs_default.c:vfswrap_is_offline we
see the following:

        status = get_full_smb_filename(talloc_tos(), fname, &path);
        if (!NT_STATUS_IS_OK(status)) {
                errno = map_errno_from_nt_status(status);
                return false;
        }

        return (dmapi_file_flags(path) & FILE_ATTRIBUTE_OFFLINE) != 0;

Should the path that was allocated above be freed? Sure, it will get
cleaned up, but perhaps it should be explicitly freed.

-- 
Regards,
Richard Sharpe


More information about the samba-technical mailing list