A patch to move FSCTL handling into the VFS

Richard Sharpe realrichardsharpe at gmail.com
Sat Sep 24 11:52:55 MDT 2011

On Wed, Sep 21, 2011 at 9:02 PM, Richard Sharpe
<realrichardsharpe at gmail.com> wrote:
> On Wed, Sep 21, 2011 at 5:46 PM, Rusty Russell <rusty at ozlabs.org> wrote:
>> On Fri, 16 Sep 2011 11:58:04 -0700, Richard Sharpe <realrichardsharpe at gmail.com> wrote:
>>> 2. Is the handling of talloc correct. Ie, will these allocations get
>>> cleaned up when the request completes. I used
>>> talloc_size(talloc_tos(), ...) mostly.
>> Yes, that looks wrong (I have no idea about this code, BTW, just that I
>> know something about talloc).
>> You usually want to use talloc_array, which gives you type checking:

OK, I have attached the latest patch with a fix for this issue to the
bug report in bugzilla.


It has been tested with my torture test.

Further comments welcome.

Richard Sharpe

More information about the samba-technical mailing list