[Server signing] Samba fileshare not working with server signing =auto.

[okmanoj]

While debugging i found we are not updating smb_signing_state.bsrspyl in file share operation due to which below code is always returning without adding sign flags and signature (even tough it is hard coded as per windows behavior)
<code><pre>void smb_signing_sign_pdu(struct smb_signing_state *si,                          uint8_t *outbuf, uint32_t seqnum){        uint8_t calc_md5_mac[16];        uint16_t flags2;
        if (si->mac_key.length == 0) {                if (!si->bsrspyl) {                        return;                }        }</pre></code>

I tried to make patch for this, and tested all the modes auto, mandatory and disable and signing flags in SMB header (Flags2) [0x0004] and Security mode  (i.e Signatures and Sig req) are added properly
I request for patch review and let me know your comments.

Best RegardsManoj

--
View this message in context: http://samba.2283325.n4.nabble.com/Server-signing-Samba-fileshare-not-working-with-server-signing-auto-tp3720645p3800583.html
Sent from the Samba - samba-technical mailing list archive at Nabble.com.